lame attempt to broaden plugin access to new page logic#209
Open
WardCunningham wants to merge 1 commit intolegacyfrom
Open
lame attempt to broaden plugin access to new page logic#209WardCunningham wants to merge 1 commit intolegacyfrom
WardCunningham wants to merge 1 commit intolegacyfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not to be merged without serious consideration.
This is some work in progress on a plugin that now slips my mind required access to link.showPage but found that logic deeper in the refresh cycle had unfortunate assumptions (unnecessary dependencies) that stalled this work.
(It is coming back to me now. It was print logic in the never finished table of contents plugin.)
We are well overdue for a rethink of how plugins might cooperate with core-javascript. Ideas?