RFC: Adding a presave hook in editor focusoutHandler#279
Open
andrewshell wants to merge 1 commit intofedwiki:legacyfrom
Open
RFC: Adding a presave hook in editor focusoutHandler#279andrewshell wants to merge 1 commit intofedwiki:legacyfrom
andrewshell wants to merge 1 commit intofedwiki:legacyfrom
Conversation
Member
|
A while back I created a feature to allow plugins to override the editor. It's not the same thing as the presave hook you've proposed, but I think reaching for similar kinds of extensions. |
andrewshell
force-pushed
the
editor-presave-hook
branch
from
39968af to
b00c9f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm curious if there have been any conversations about providing hooks in the code to allow plugins to extend core functionality. Here is an example of adding a "presave" hook to the editor.
I've created a plugin that would use this hook as a proof of concept.
https://github.com/andrewshell/wiki-plugin-metadata/blob/master/client/metadata.js#L26-L35
I'm sure there will need to be discussions before something like this gets merged. So I'm documenting the idea with working code.