Conversation
WardCunningham
approved these changes
Jun 10, 2025
Member
WardCunningham
left a comment
WardCunningham
left a comment
There was a problem hiding this comment.
It looks like there was a plan once. Nice to see it come to completion.
Member
Author
|
Further testing shows this is not quite right.
I think the original intention could have been to save to local if not logged in and also if the edit as on a page specifically loaded from local. |
use `isOwner` as a hint if the user is the wiki owner. this is set initially by the server. If the value is incorrectly `true`, it just means there will be a server roundtrip before writing to local storage.
don't push to local if this is a fork action.
WardCunningham
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if we remember we're forking from local the change from
localtoviewin the location bar, and elsewhere, will get fixed up correctly.