Conversation
for relative URLs. protocol is not used, so make a non-capturing group wrap protocol group with a non-capturing group that matchs on protocol, or a leading '/', to add support for relative external links.
WardCunningham
approved these changes
Aug 21, 2025
Member
WardCunningham
left a comment
WardCunningham
left a comment
There was a problem hiding this comment.
Thanks for the zoom walkthrough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned on 20 Aug, adding support for using relative URLs in an external link. This removes the need for an external link to start with a protocol, though relative URLs must start with a
/.Replace
rel="nofollow", as it has no real meaning, withrel="noopener", so the new tab/window will not share browsing context.Use non-capturing groups for thing being matched (protocol), but we don't use in the replacement function, and remove them from the function's signature.
There is a remote risk that there is text match somewhere that will match as an external link, when it shouldn't. Probably a risk worth taking? Thoughts.