Skip to content

Conversation

@binaryseed
Copy link
Collaborator

@binaryseed binaryseed commented Apr 9, 2025

This PR updates the felt_python library with all the latest capabilities from the Felt REST API

  • Includes notebooks that walk through examples of using the new functions
  • Includes tests that cover most of the functionality
  • Sets up CI to run the tests

Also closes #21

@binaryseed binaryseed force-pushed the vince/update-library branch from 7574284 to c796e18 Compare April 9, 2025 01:30
@binaryseed binaryseed force-pushed the vince/update-library branch from 0ada2c5 to dd41020 Compare April 9, 2025 16:34
@binaryseed binaryseed requested a review from arredond April 9, 2025 23:22
@binaryseed binaryseed force-pushed the vince/update-library branch from 60b8681 to f336b3a Compare April 9, 2025 23:38
@binaryseed binaryseed marked this pull request as ready for review April 10, 2025 16:15
Copy link
Collaborator

@arredond arredond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the direction of this! Keeping the library up to date with the Felt API and adding tests is really invaluable. Left some small notes (mostly nits).



def list_elements_in_group(
def show_element_group(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "show" the right term here? This still returns a list, it doesn't print anything. The developer docs also say "list" so we should keep these consistent

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, show isn't correct here. To match all the other endpoint functions, this would be get_element_group.

The old list_elements_in_group makes sense when you read it, but doesn't follow the naming pattern. For example, we have get_layer_group not list_layers_in_group.

Also it technically returns a GeoJSON object, not a literal list.

I'll change it to get_element_group for now and we can consider if we should keep that or just stick with the old function.

@binaryseed binaryseed merged commit 394bc83 into main Apr 11, 2025
1 check passed
@binaryseed binaryseed deleted the vince/update-library branch April 11, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

move_map not in __all__

3 participants