Merged
Conversation
Collaborator
afreyer
commented
Jun 9, 2025
afreyer
commented
- Enhanced BASEOBJ class and COLOR function to support material properties:
- Add opacity and shininess attributes to BASEOBJ constructor
- Update VIEWBASE function to pass material properties to visualizer
- Extend COLOR function with opacity and shininess parameters
- Include validation for opacity and shininess values (0.0-1.0 range)
…rt to objects Enhanced BASEOBJ class and COLOR function to support material properties: - Add opacity and shininess attributes to BASEOBJ constructor - Update VIEWBASE function to pass material properties to visualizer - Extend COLOR function with opacity and shininess parameters - Include validation for opacity and shininess values (0.0-1.0 range)
- Correct variable names in opacity/shininess assignment - Replace 'object' with 'obj' and 'x' in COLOR function to fix attribute assignment for material properties.
Move opacity and shininess assignment to setcolor method and extract alpha from RGBA color lists. This centralizes material property management and ensures consistent RGB storage for visualization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.