You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks so much! A few things I noticed at quick glance:
— CSS clean-up: Noticed there were several H# tags used. Should consolidate into just H2 since it's just one heading. Same for p tags. Consolidate all sentences into a single paragraph. Also noticed unused classes.
— Import only the Google font weights/styles in use instead of the entire font family.
— Responsive design: How did you want to handle tablet and mobile views?
— Body text: The typeface News Cycle doesn't connect with the heading. I suggest something like Trocchi or something that matches the geometry of Libre Baskerville at least. Here's a short guide from HF&J on combining typefaces: http://www.typography.com/techniques/
Happy to dive into this over the weekend when I have more time if you don't get a chance to address during the week.
The reason will be displayed to describe this comment to others. Learn more.
rebase derp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
css and index should be here