Conversation
* recognize two chunks formats * Trim gap before first chunk * Print dat header You have to investigate chunk offsets before cut bin file
|
Nice ! Never expected to get pull reqs on this project... |
|
|
||
| #define FMT_CHUNK_EXT 0x80 | ||
| #define CRC_TAIL_LEN 3 | ||
| #define MAX_DAT_OFFSET 0xffffff |
There was a problem hiding this comment.
I assume MAX_DAT_OFFSET is to cover the maximum "AH:AM:AL" value ?
| rf->dbuf = malloc(file_len); | ||
| // Allocate max size for output according to offset field dimension | ||
| rf->dbuf_size = MAX_DAT_OFFSET; | ||
| rf->dbuf = malloc(rf->dbuf_size); |
There was a problem hiding this comment.
Ok, but maybe the size should be +1 : if the last chunk has len=0x80 starting at 0xff ff80 then the last byte would overflow.
|
|
||
| char ver_str[6]; // e.g. LBC ZE1/ VCM | ||
|
|
||
| uint32_t off17; // 00 00 00 80 |
There was a problem hiding this comment.
If I count properly, this field is not 4-byte aligned in the (packed) struct, correct ?
| printf("\n"); | ||
| } | ||
|
|
||
| void unpack_dat(FILE *outf, struct datfile *rf, bool trim) { |
There was a problem hiding this comment.
yes, passing in a struct * is good
Can you add a comment for argument "trim"
| temp_addr >>= 8; | ||
| if (temp_addr != (curaddr + DCHUNK_DLEN)) { | ||
| printf("addr skip @ %lX\n", (unsigned long) temp_addr); | ||
| const dat_header_t *dath = (const dat_header_t *)src; |
There was a problem hiding this comment.
I don't like casting a raw buffer to a struct like this, especially if the struct has unaligned bytes. It also leads to assuming host endianness.
Either at least memcpy to your struct (and mark the struct with __attribute packed etc), or copy the elements one by one with reconst_XX() as required.
| const chunk_t *ch = NULL; | ||
| if (ch_header->fmt == FMT_CHUNK_EXT) { | ||
| // 80 SRC TGT LEN 34 82 | ||
| ch = (chunk_t*)((uint8_t*)ch_header + sizeof(chunk_header_t)); |
| } | ||
| // TODO check whether ch buffer is not go beyond the end of file | ||
|
|
||
| if (ch->cmd != 0x8234) { |
There was a problem hiding this comment.
Here, you're assuming host endianness. Why not memcmp() with pm[] ?
| break; | ||
| } | ||
|
|
||
| offset = ch->offset_hi << 16 | ch->offset_mid << 8 | ch->offset_low; |
There was a problem hiding this comment.
I would prefer either using a truncated reconst_32() call like I did, or better, adding a reconst_24() to nislib.c+h
| dest = rf->dbuf + offset; | ||
| memcpy(dest, ch->payload, chklen); | ||
|
|
||
| ch_header = (const chunk_header_t *)((uint8_t*)ch + offsetof(chunk_t, payload) + chklen + CRC_TAIL_LEN); |
|
|
||
| if (argc !=3) { | ||
| printf("%s <file.dat> <out.dat> : unpack payload to <out.dat> etc\n",argv[0]); | ||
| if (argc < 3) { |
2 participants
You have to investigate chunk offsets before cut bin file