Skip to content

Skymap inconsistency fixed.#658

Open
ndilalla wants to merge 1 commit intomasterfrom
fix_skymap_issue_619
Open

Skymap inconsistency fixed.#658
ndilalla wants to merge 1 commit intomasterfrom
fix_skymap_issue_619

Conversation

@ndilalla
Copy link
Contributor

Fixed some inconsistencies and bugs in the skymap library:

  • Use tuple indexing (instead of list indexing) so advanced indexing matches the array layout for 2D and 3D maps
  • Return shape aligned with HEALPix, so that the result is now returned as (ne, np) (energy × sky points) instead of (np, ne), so WCS and HEALPix get_map_values() have the same convention
  • Updated docstrings to better explain that the internal array is (energy, lat, lon) (and (lat, lon) for 2D)

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.78%. Comparing base (92cf94f) to head (9f6f897).

Files with missing lines Patch % Lines
fermipy/skymap.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
- Coverage   50.79%   50.78%   -0.01%     
==========================================
  Files         143      143              
  Lines       27265    27269       +4     
==========================================
  Hits        13849    13849              
- Misses      13416    13420       +4     
Flag Coverage Δ
unittests 50.78% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments