Skip to content

Using prefix keyword in psmap.#660

Open
ndilalla wants to merge 1 commit intomasterfrom
fix_prefix_psmap_643
Open

Using prefix keyword in psmap.#660
ndilalla wants to merge 1 commit intomasterfrom
fix_prefix_psmap_643

Conversation

@ndilalla
Copy link
Contributor

This PR solves issue #643. List of changes:

  1. Use prefix in the map name:
  • o['name'] = utils.join_strings([prefix, 'PSmap']) so with prefix='state1' the name is state1_PSmap.
  • with prefix='' it stays PSmap.
  1. Use prefix for the default FITS path:
  • With no outfile, path is utils.format_filename(self.workdir, 'PSmap', prefix=[prefix]), so e.g. state1_PSmap.fits when a prefix is set.
  1. Stopped overwriting o['name'] with outfile:
  • o['name'] is always utils.join_strings([prefix, 'PSmap']) so that plot filenames always respect prefix.
  • Only the FITS path is taken from outfile when it’s provided.

@ndilalla ndilalla requested a review from omodei February 19, 2026 23:09
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.79%. Comparing base (92cf94f) to head (5da6366).

Files with missing lines Patch % Lines
fermipy/psmap.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #660   +/-   ##
=======================================
  Coverage   50.79%   50.79%           
=======================================
  Files         143      143           
  Lines       27265    27263    -2     
=======================================
  Hits        13849    13849           
+ Misses      13416    13414    -2     
Flag Coverage Δ
unittests 50.79% <91.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments