Skip to content

Conversation

@jhdark
Copy link
Collaborator

@jhdark jhdark commented Jan 13, 2025

Proposed changes

Fix for #861

Now certain classes such as DerivedQuantities, Traps and Exports now inherent from List, they no longer need attributes of themselves. The attributes were kept for backwards compatibility, but have been warned for the past two releases and now can be deprecated.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jhdark jhdark added the enhancement New feature or request label Jan 13, 2025
@codecov
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.25%. Comparing base (8d6857b) to head (79f5d3e).
Report is 67 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
- Coverage   99.27%   99.25%   -0.02%     
==========================================
  Files          60       60              
  Lines        2753     2701      -52     
==========================================
- Hits         2733     2681      -52     
  Misses         20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RemDelaporteMathurin RemDelaporteMathurin linked an issue Jan 14, 2025 that may be closed by this pull request
@RemDelaporteMathurin RemDelaporteMathurin merged commit 8d8f7d9 into festim-dev:main Jan 14, 2025
6 checks passed
@jhdark jhdark deleted the depricate_list_attributes branch March 3, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate derived_quantities, traps, exports etc

2 participants