Skip to content

BREAKING CHANGE: make lucide-react peer dependency and don't export unnecessary files #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmaciej-neti merged 2 commits into from
Jul 24, 2025
Merged

BREAKING CHANGE: make lucide-react peer dependency and don't export unnecessary files #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54d2118
BREAKING CHANGE: make lucide-react peer dependency and don't export u…
tmaciej-neti Jul 24, 2025
26ca2ef
test: update test snapshots
tmaciej-neti Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"author": "Neti",
"license": "ISC",
"peerDependencies": {
"lucide-react": "^0.525.0",
"react": "^18 || ^19"
},
"devDependencies": {
Expand Down Expand Up @@ -70,7 +71,6 @@
"@radix-ui/react-slot": "^1.1.2",
"class-variance-authority": "^0.7.1",
"clsx": "^2.1.1",
"lucide-react": "^0.474.0",
"react-hook-form": "^7.54.2",
"tailwind-merge": "^2.6.0",
"zod": "^3.24.2"
Expand Down
4 changes: 4 additions & 0 deletions src/components/__snapshots__/alert.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ exports[`Button component > renders correctly for variant default 1`] = `
role="alert"
>
<svg
aria-hidden="true"
class="lucide lucide-info"
fill="none"
height="24"
Expand Down Expand Up @@ -53,6 +54,7 @@ exports[`Button component > renders correctly for variant destructive 1`] = `
role="alert"
>
<svg
aria-hidden="true"
class="lucide lucide-info"
fill="none"
height="24"
Expand Down Expand Up @@ -99,6 +101,7 @@ exports[`Button component > renders correctly for variant error 1`] = `
role="alert"
>
<svg
aria-hidden="true"
class="lucide lucide-info"
fill="none"
height="24"
Expand Down Expand Up @@ -145,6 +148,7 @@ exports[`Button component > renders correctly for variant warning 1`] = `
role="alert"
>
<svg
aria-hidden="true"
class="lucide lucide-info"
fill="none"
height="24"
Expand Down
13 changes: 2 additions & 11 deletions tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,13 @@
import { defineConfig } from "tsup";

const tsupConfig = defineConfig((options) => ({
entry: [
"src/index.ts",
"src/global.css",
"src/**/*.ts",
"src/**/*.tsx",
"!src/**/*.spec.ts",
"!src/**/*.spec.tsx",
"!src/**/*.stories.ts",
"!src/**/*.stories.tsx",
],
entry: ["src/index.ts", "src/global.css"],
dts: true,
clean: true,
sourcemap: true,
minify: !options.watch,
treeshake: true,
external: ["react", "react/jsx-runtime"],
external: ["react", "react/jsx-runtime", "lucide-react"],
}));

export default tsupConfig;