Skip to content

Conversation

@sherali42
Copy link
Contributor

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

rename last-delta-histogram to readable name delta-histogram-v2

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the last-delta-histogram schema to delta-histogram-v2 to improve naming clarity and readability. The old name last-delta-histogram was less intuitive, while delta-histogram-v2 better indicates it's an evolved version of the delta histogram schema.

  • Renamed Scala variable lastDeltaHistogram to deltaHistogramV2 in the Schemas object
  • Updated schema configuration key from last-delta-histogram to delta-histogram-v2
  • Updated all references to use the new naming

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
core/src/main/scala/filodb.core/metadata/Schemas.scala Updated the schema variable name from lastDeltaHistogram to deltaHistogramV2
core/src/main/resources/filodb-defaults.conf Renamed schema configuration from last-delta-histogram to delta-histogram-v2 including the downsample-schema reference
gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala Updated the schema reference in writeLastDeltaHistRecord to use deltaHistogramV2

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants