Skip to content

Conversation

@stratakis
Copy link
Contributor

scikit-learn 1.8.0+ removed the algorithm parameter from AdaBoostClassifier

scikit-learn/scikit-learn#32262

The changes maintain compatibility with previous version of scikit-learn

🙇💖 Thank you for contributing to NiaAML!

🚮 feel free to delete any section that is not helpful/required for your report (including this message)

❗ Issue Links

Fixes #98

🧪 How Has This Been Tested?

I've tested it on Fedora Rawhide with both scikit-learn 1.7.2 and scikit-learn 1.8.0rc1 and all the tests pass

✅ Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

scikit-learn 1.8.0+ removed the algorithm parameter from AdaBoostClassifier

scikit-learn/scikit-learn#32262

The changes maintain compatibility with previous version of scikit-learn
@firefly-cpp
Copy link
Owner

Thanks, @stratakis!

@firefly-cpp
Copy link
Owner

@stratakis, should we also update the pyproject.toml and poetry.lock files to version 1.8 or higher?

@stratakis
Copy link
Contributor Author

@stratakis, should we also update the pyproject.toml and poetry.lock files to version 1.8 or higher?

This change works fine with version 1.6, as the algorithm parameter was deprecated at that version, so no need for updating the dependency pin.

Not sure about the CI though, it seems the macos build is failing.

@firefly-cpp firefly-cpp merged commit 7093ace into firefly-cpp:master Dec 4, 2025
0 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecations

2 participants