Ignore empty value for certain category attributes#144
Open
PaulEmich wants to merge 1 commit intofiregento:developfrom
Open
Ignore empty value for certain category attributes#144PaulEmich wants to merge 1 commit intofiregento:developfrom
PaulEmich wants to merge 1 commit intofiregento:developfrom
Conversation
mitchelvk
added a commit
to madebymouses/FireGento_FastSimpleImport2
that referenced
this pull request
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Magento has the following attributes which are allowed to be overruled by marking the "use config" checkbox.
Using this importer I did not find any way to pass an empty value for these required attributes, hence this pull request.
During the category validation in Magento (
\Magento\Catalog\Model\CategoryRepository::validateCategory) these fields are stored in a data attribute nameduse_post_data_config. If no value is passed for these fields the required validation gets ignored.This pull request kind of copies this behaviour and allows the user to pass an empty value in the category importer.