Add timeout to vad #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a timeout mechanism to the Voice Activity Detection (VAD) system to debounce speech end events. The changes refactor the VAD handling logic to use a configurable timeout before releasing the active speaker, preventing premature floor releases during brief speech pauses.
Key Changes:
- Introduced a timeout-based debouncing mechanism for VAD speech end events
- Refactored VAD start/end logic into dedicated helper methods (
startVADandendVAD) - Updated speech state detection logic to use
speech.stateinstead of separatespeech.startandspeech.endchecks
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
deep-sea-stories/packages/backend/src/service/audio-streaming-orchestrator.ts
Show resolved
Hide resolved
deep-sea-stories/packages/backend/src/service/audio-streaming-orchestrator.ts
Show resolved
Hide resolved
deep-sea-stories/packages/backend/src/service/audio-streaming-orchestrator.ts
Show resolved
Hide resolved
czerwiukk
approved these changes
Dec 8, 2025
czerwiukk
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.