Bugfix/enable disable country region reports by fivetran-avinash · Pull Request #158 · fivetran/dbt_ad_reporting

fivetran-avinash · 2025-08-05T19:56:13Z

PR Overview

Package version introduced in this PR:

v2.0.1

This PR addresses the following Issue/Feature(s):

[[Bug] Handle disabling the country and region reports when all upstream models are missing #155]

Summary of changes:

Get rid of compilation errors for non-present tables.

Submission Checklist

Alignment meeting with the reviewer (if needed)
- Timeline and validation requirements discussed
Provide validation details:
- Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
- Testing Instructions: Confirm the change addresses the issue(s)
- Focus Areas: Complex logic or queries that need extra attention
Merge any relevant open PRs into this PR

Changelog

Draft changelog for PR
Final changelog for release review

fivetran-avinash · 2025-08-12T00:24:54Z

models/ad_reporting__monthly_campaign_region_report.sql

+-- Used for logging macro behavior, can be removed after PR review
+{{ log("include_list before filtering for region report: " ~ include_list, info=True) }}


Remove after PR review

Suggested change

-- Used for logging macro behavior, can be removed after PR review

{{ log("include_list before filtering for region report: " ~ include_list, info=True) }}

fivetran-avinash · 2025-08-12T00:25:20Z

models/ad_reporting__monthly_campaign_region_report.sql

+-- Used for logging macro behavior, can be removed after PR review
+{{ log("enabled_packages after macro filtering for region report: " ~ enabled_packages, info=True) }}
+{{ log("Model enabled for region report? " ~ is_enabled(enabled_packages), info=True) }}


Remove after PR review

Suggested change

-- Used for logging macro behavior, can be removed after PR review

{{ log("enabled_packages after macro filtering for region report: " ~ enabled_packages, info=True) }}

{{ log("Model enabled for region report? " ~ is_enabled(enabled_packages), info=True) }}

fivetran-avinash · 2025-08-12T00:25:54Z

models/ad_reporting__monthly_campaign_country_report.sql

+-- Used for logging macro behavior, can be removed after PR review
+{{ log("include_list before filtering for country report: " ~ include_list, info=True) }}


Remove after PR review

Suggested change

-- Used for logging macro behavior, can be removed after PR review

{{ log("include_list before filtering for country report: " ~ include_list, info=True) }}

fivetran-avinash · 2025-08-12T00:26:00Z

models/ad_reporting__monthly_campaign_country_report.sql

+-- Used for logging macro behavior, can be removed after PR review
+{{ log("enabled_packages after macro filtering for country report: " ~ enabled_packages, info=True) }}
+{{ log("Model enabled for country report? " ~ is_enabled(enabled_packages), info=True) }}


Remove after PR review

Suggested change

-- Used for logging macro behavior, can be removed after PR review

{{ log("enabled_packages after macro filtering for country report: " ~ enabled_packages, info=True) }}

{{ log("Model enabled for country report? " ~ is_enabled(enabled_packages), info=True) }}

fivetran-avinash · 2025-08-12T00:26:12Z

models/intermediate/int_ad_reporting__monthly_campaign_country_report.sql

+-- Used for logging macro behavior, can be removed after PR review
+{{ log("include_list before filtering for intermediate country report: " ~ include_list, info=True) }}


Remove after PR review

Suggested change

-- Used for logging macro behavior, can be removed after PR review

{{ log("include_list before filtering for intermediate country report: " ~ include_list, info=True) }}

fivetran-avinash · 2025-08-12T00:26:50Z

models/intermediate/int_ad_reporting__monthly_campaign_country_report.sql

+-- Used for logging macro behavior, can be removed after PR review
+{{ log("enabled_packages after macro filtering for intermediate country report: " ~ enabled_packages, info=True) }}
+{{ log("Model enabled for intermediate country report? " ~ is_enabled(enabled_packages), info=True) }}


Remove after PR review

Suggested change

-- Used for logging macro behavior, can be removed after PR review

{{ log("enabled_packages after macro filtering for intermediate country report: " ~ enabled_packages, info=True) }}

{{ log("Model enabled for intermediate country report? " ~ is_enabled(enabled_packages), info=True) }}

fivetran-avinash · 2025-08-12T00:26:55Z

models/intermediate/int_ad_reporting__monthly_campaign_region_report.sql

+-- Used for logging macro behavior, can be removed after PR review
+{{ log("include_list before filtering for intermediate region report: " ~ include_list, info=True) }}


Remove after PR review

Suggested change

-- Used for logging macro behavior, can be removed after PR review

{{ log("include_list before filtering for intermediate region report: " ~ include_list, info=True) }}

fivetran-avinash · 2025-08-12T00:27:01Z

models/intermediate/int_ad_reporting__monthly_campaign_region_report.sql

+-- Used for logging macro behavior, can be removed after PR review
+{{ log("enabled_packages after macro filtering for intermediate region report: " ~ enabled_packages, info=True) }}
+{{ log("Model enabled for intermediate region report? " ~ is_enabled(enabled_packages), info=True) }}


Remove after PR review

Suggested change

-- Used for logging macro behavior, can be removed after PR review

{{ log("enabled_packages after macro filtering for intermediate region report: " ~ enabled_packages, info=True) }}

{{ log("Model enabled for intermediate region report? " ~ is_enabled(enabled_packages), info=True) }}

…//github.com/fivetran/dbt_ad_reporting into bugfix/enable-disable-country-region-reports

fivetran-catfritz

lgtm!

CHANGELOG.md

Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>

fivetran-joemarkiewicz

LGTM with one reminder to make a README update following a correction already applied in this PR for quickstart.

fivetran-joemarkiewicz · 2025-08-25T14:20:35Z

.quickstart/quickstart.yml

@@ -1,4 +1,4 @@
-dbt_versions: '>=1.3.0 <2.0.0'
+dbt_versions: '>=1.6.0 <2.0.0'


Let's also update the badge in the README to show the proper version range.

…//github.com/fivetran/dbt_ad_reporting into bugfix/enable-disable-country-region-reports

fivetran-avinash added 7 commits August 5, 2025 12:52

Enable/disable country & region reports

435930d

Seed rename

76f5378

Seed rename

c0ebe32

include include

5a0e99d

include include

c013f02

Logs

ae7476f

Fix enable/disable country & region reports behavior

94023eb

fivetran-avinash commented Aug 12, 2025

View reviewed changes

schema

a312902

fivetran-avinash marked this pull request as ready for review August 12, 2025 16:33

fivetran-avinash self-assigned this Aug 12, 2025

fivetran-avinash and others added 6 commits August 12, 2025 15:38

Range version updates

f30b851

Merge branch 'main' into bugfix/enable-disable-country-region-reports

7bd1c77

Update packages.yml

3e1aa8d

Merge branch 'bugfix/enable-disable-country-region-reports' of https:…

fe26ec5

…//github.com/fivetran/dbt_ad_reporting into bugfix/enable-disable-country-region-reports

Macro fix, reverted model fixes

45c8ad6

formatting

b3bb4b8

fivetran-catfritz approved these changes Aug 22, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

73d073c

Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>

fivetran-avinash added the docs:ready Triggers the docs generator workflow. label Aug 22, 2025

Generate dbt docs via GitHub Actions

47614c2

fivetran-joemarkiewicz approved these changes Aug 25, 2025

View reviewed changes

README

7bba287

Merge branch 'bugfix/enable-disable-country-region-reports' of https:…

8525b2a

…//github.com/fivetran/dbt_ad_reporting into bugfix/enable-disable-country-region-reports

fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Aug 25, 2025

Generate dbt docs via GitHub Actions

d38753d

fivetran-avinash merged commit 4a22e85 into main Aug 25, 2025
8 checks passed

		-- Used for logging macro behavior, can be removed after PR review
		{{ log("include_list before filtering for region report: " ~ include_list, info=True) }}

	-- Used for logging macro behavior, can be removed after PR review
	{{ log("enabled_packages after macro filtering for region report: " ~ enabled_packages, info=True) }}
	{{ log("Model enabled for region report? " ~ is_enabled(enabled_packages), info=True) }}

	-- Used for logging macro behavior, can be removed after PR review
	{{ log("enabled_packages after macro filtering for country report: " ~ enabled_packages, info=True) }}
	{{ log("Model enabled for country report? " ~ is_enabled(enabled_packages), info=True) }}

	-- Used for logging macro behavior, can be removed after PR review
	{{ log("enabled_packages after macro filtering for intermediate country report: " ~ enabled_packages, info=True) }}
	{{ log("Model enabled for intermediate country report? " ~ is_enabled(enabled_packages), info=True) }}

	-- Used for logging macro behavior, can be removed after PR review
	{{ log("enabled_packages after macro filtering for intermediate region report: " ~ enabled_packages, info=True) }}
	{{ log("Model enabled for intermediate region report? " ~ is_enabled(enabled_packages), info=True) }}

		@@ -1,4 +1,4 @@
		dbt_versions: '>=1.3.0 <2.0.0'
		dbt_versions: '>=1.6.0 <2.0.0'

Conversation

fivetran-avinash commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Overview

Submission Checklist

Changelog

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-catfritz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fivetran-avinash commented Aug 5, 2025 •

edited

Loading

fivetran-avinash Aug 12, 2025 •

edited

Loading