Conversation
Contributor
fivetran-jamie
left a comment
fivetran-jamie
left a comment
There was a problem hiding this comment.
Looks great -- just one suggestion in the changelog.
Otherwise I added pre-merge suggestions in the packages.yml for when FB and Reddit are live
CHANGELOG.md
Outdated
Comment on lines
6
to
7
| - Increases the required facebook_ads package to version 1.3.0. | ||
| - Increases the required reddit_ads package to version 1.3.0. |
Contributor
There was a problem hiding this comment.
Could you add links to the FB and Reddit 1.3.0 release notes/changelog?
Contributor
Author
There was a problem hiding this comment.
Done! Just waiting on release review of facebook_ads.
Contributor
Author
There was a problem hiding this comment.
Link will be broken until merge into main.
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
fivetran-jamie
approved these changes
Dec 22, 2025
Contributor
fivetran-jamie
left a comment
fivetran-jamie
left a comment
There was a problem hiding this comment.
LGTM! Reminder to regen docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
Submission Checklist
Changelog