[Prerelease] Apply home currency exchange rate to fix unneeded multicurrency issues.

[fivetran-avinash]

PR Overview

Package version introduced in this PR:

• 1.1.1-a2

This PR addresses the following Issue/Feature(s):

• Pre-release to allow more multicurrency flexibilty for a home currency exchange rate variable.

Summary of changes:

• Ensures that amounts that aren't already in a home currency aren't converted. Pins "USD" to satisfy a specific customer.

Submission Checklist

• Alignment meeting with the reviewer (if needed)
  • Timeline and validation requirements discussed
• Provide validation details:
  • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
  • Testing Instructions: Confirm the change addresses the issue(s)
  • Focus Areas: Complex logic or queries that need extra attention
• Merge any relevant open PRs into this PR

Changelog

• Draft changelog for PR
• Final changelog for release review

[fivetran-joemarkiewicz]

A few comments before pre-release approval

[fivetran-joemarkiewicz]

In an effort to not maintain two versions of the same original case statement I believe we should only use the variable case when on the original lines 215 and 216 where it's required. Otherwise, I worry about us updating one of these case statements and not updating the other in a future update.

[fivetran-joemarkiewicz]

For example, I'm thinking something along the lines of the following (this will need to be verified):

Suggested change

	case
	when invoices.currency_id = '{{ var('quickbooks__home_currency', '') }}'
	then case when invoice_lines.bundle_id is not null and invoices.total_amount = 0
	then invoices.total_amount
	else coalesce(invoice_bundles.amount, invoice_lines.amount)
	end
	when invoice_lines.bundle_id is not null and invoices.total_amount = 0
	then invoices.total_amount * coalesce(invoices.exchange_rate, 1)
	else coalesce(invoice_bundles.amount, invoice_lines.amount) * coalesce(invoices.exchange_rate, 1)
	case when invoice_lines.bundle_id is not null and invoices.total_amount = 0
	then
	case when invoices.currency_id = '{{ var('quickbooks__home_currency', '') }}'
	then invoices.total_amount
	else (invoices.total_amount * coalesce(invoices.exchange_rate, 1))
	else
	case when invoices.currency_id = '{{ var('quickbooks__home_currency', '') }}'
	then coalesce(invoice_bundles.amount, invoice_lines.amount)
	else (coalesce(invoice_bundles.amount, invoice_lines.amount) * coalesce(invoices.exchange_rate, 1))

This way the original case statement persists with no repeated logic other than the variable case statement.

[fivetran-avinash]

I was realizing this code is a bit repetitive, so I tried and simplified it to separate out the bundle component of this logic and the exchange rate application. Whiteboarded it and I believe it retains the initial logic. Let me know your thoughts.

[fivetran-joemarkiewicz]

Same comment as the other multi case statement and leaning more towards only maintaining one version of the original case statement.

[fivetran-avinash]

Also simplified the logic here, let me know your thoughts.

[fivetran-avinash]

@fivetran-joemarkiewicz Ready for re-review.