Fivetran catfritz patch 1#42
Merged
fivetran-savage merged 11 commits intofeature/union-datafrom Nov 11, 2025
Merged
Conversation
Refactor date calculation logic to use a query for min and max dates.
…an/dbt_recharge into fivetran-catfritz-patch-1 merge
Added a comment to clarify the date calculation logic.
Added comment for year range creation logic.
Ensure first_date and last_date are strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I applied the same concept to the date spine as in stg_mixpanel__user_event_date_spine.
It was actually the non-
flags.whichcondition's contents that wasn’t correct before.I remembered we had a similar issue in other date spines after we added
flags.which.