Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

bug/business-account-freshness#16

Merged
fivetran-catfritz merged 4 commits intomainfrom
bug/business-account-freshness
Jul 7, 2025
Merged

bug/business-account-freshness#16
fivetran-catfritz merged 4 commits intomainfrom
bug/business-account-freshness

Conversation

@fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Jul 7, 2025

PR Overview

Package version introduced in this PR:

  • v0.6.1

This PR addresses the following Issue/Feature(s):

Summary of changes:

  • Adds var ad_reporting__reddit_ads_enabled to the enabled config for sources business_account and account.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
      • Was able to reproduce the bug when setting ad_reporting__reddit_ads_enabled to false. This update resolves it.
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-catfritz fivetran-catfritz self-assigned this Jul 7, 2025
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-catfritz Approved!

@fivetran-catfritz fivetran-catfritz merged commit 28003ec into main Jul 7, 2025
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Regression: enabled source and freshness checks when not using Reddit Ads

3 participants