Conversation
| .SHELLFLAGS := -eu -o pipefail -c | ||
|
|
||
| # mkosi version | ||
| MKOSI_COMMIT := a425313c5811d2ed840630dbfc45c6bc296bfd48 |
There was a problem hiding this comment.
lets avoid putting project dependency versions in the Makefile. main branch is using Nix which I think is too heavy for bnet images use-case (we don't need to install system tools).
Below you're also opting to use pip for dependency management. Originally, I intentionally avoided relying on any single tool for Python dependency management as there is no one blessed tool in the Python ecosystem and people use whatever (pip, pipx, poetry, uv).
Let's first discuss which dependency management tool we want to use for the project. I personally like uv.
To not block the PR on the tool selection decision let's proceed with the current implementation of the Makefile and come back to it later.
There was a problem hiding this comment.
I have added TODO to the Makefile to revisit tooling choice.
...rofiles/playground/mkosi.extra/etc/systemd/system/serial-getty@hvc0.service.d/autologin.conf
Outdated
Show resolved
Hide resolved
3e31b42 to
d207de0
Compare
…ith builder-playground
508643b to
6dc482e
Compare
No description provided.