feat: nginx 采集插件添加对 tengine request_time 采集支持#1408
Merged
kongfei605 merged 2 commits intoflashcatcloud:mainfrom Feb 26, 2026
Merged
feat: nginx 采集插件添加对 tengine request_time 采集支持#1408kongfei605 merged 2 commits intoflashcatcloud:mainfrom
kongfei605 merged 2 commits intoflashcatcloud:mainfrom
Conversation
Signed-off-by: ruochen <wanxialianwei@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for collecting the request_time metric from Tengine's nginx status endpoint and updates the sonic JSON library to version 1.15.0.
Changes:
- Added parsing logic for the optional 4th field (
request_time) in the nginx stub_status response, which is specific to Tengine - Updated
github.com/bytedance/sonicfrom v1.9.1 to v1.15.0 and added related dependencies - Moved
github.com/elastic/go-sysinfofrom indirect to direct dependency (likely from runninggo mod tidy)
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| inputs/nginx/nginx.go | Added conditional parsing for the optional request_time field when it exists in the status response |
| go.mod | Updated sonic library to v1.15.0, added new dependencies (gopkg, sonic/loader, cloudwego/base64x), moved elastic/go-sysinfo to direct dependency, and updated klauspost/cpuid/v2 |
| go.sum | Updated checksums for all modified and new dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
|
Tahnk you @0x0034 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
request_time指标采集支持