FOGL-4102: fix for aggregate array with timestamp #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FOGL-4102: fix for aggregate array with timestamp
MarkRiddoch
previously approved these changes
Jan 10, 2024
Member
|
Don't we have unit tests around this? What are the possible regression areas? |
Contributor
|
@pintomax This PR will soon be two years old! Are you going for a record here? Please look and determine if this is actually needed, is obsolete or has been covered since by another Jira. Let's not allow this to go into a third year! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FOGL-4102: fix for aggregate array with timestamp