-
Notifications
You must be signed in to change notification settings - Fork 9
Added support for gravity #1764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| """Returns the farfield boundary surface.""" | ||
| # Make sure the naming is the same here and what the geometry/surface mesh pipeline generates. | ||
| return GhostSurface(name="farfield", private_attribute_id="farfield") | ||
| return GhostSurface(name="farField", private_attribute_id="farField") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Farfield name change breaks registry pattern matching
High Severity
The GhostSurface name was changed from "farfield" to "farField", but simulation_params.py still uses the pattern "farfield" in _set_boundary_full_name_with_zone_name. The pattern matching in the entity registry uses case-sensitive regex (^farfield$), which won't match "farField". This means the farfield boundary's private_attribute_full_name will never be set, breaking boundary condition resolution for all users of AutomatedFarfield.


Note
Medium Risk
Adds a new solver-translated
Gravityvolume model and extends the unit system with anaccelerationdimension, which can affect parameter serialization/unit conversion and solver JSON generation. Also changes farfield ghost-surface naming (farfield→farField), which may break consumers relying on the old boundary name.Overview
Adds gravity support for simulations. Introduces a new
Gravityvolume model (direction + acceleration magnitude, optional zone scoping) and exports it inflow360.__init__.Extends units and solver translation to support gravity. Adds an
accelerationdimension/unit to the unit system and exposed units, and updates the solver translator to non-dimensionalize gravity and emit agravityblock (global or per-zone). Includes new unit tests for model validation and translation.Also aligns automated farfield boundary naming by changing the ghost surface from
farfieldtofarField, and tweaks duplicate-entity validation to ignore models whereentitiesis unset (None).Written by Cursor Bugbot for commit c858176. This will update automatically on new commits. Configure here.