Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 11, 2026

Hotfix of PR #1799 (#1799) to the main branch.
Hey @benflexcompute, please review this hotfix PR created from your original PR.


Note

Low Risk
Small, narrowly-scoped change to params serialization/validation intended to reduce warning noise; risk is limited to accidentally omitting edge_split_layers in cases where it was meant to be treated as explicitly set.

Overview
Reduces spurious validation warnings for MeshingDefaults.edge_split_layers by treating the default value as non-user-set and stripping the implicitly serialized field from payloads.

Adds strip_implicit_edge_split_layers_inplace() and applies it before local validation (validate_params_with_context) and before draft uploads (Draft.update_simulation_params), while still emitting the existing non-beta warning when users explicitly set edge_split_layers (even to the default). Includes targeted unit tests covering both constructors/model-validate paths and upload/validation behavior.

Written by Cursor Bugbot for commit a81fdaf. This will update automatically on new commits. Configure here.

@benflexcompute benflexcompute marked this pull request as ready for review February 11, 2026 21:45
@benflexcompute benflexcompute merged commit f106f28 into main Feb 11, 2026
21 checks passed
@benflexcompute benflexcompute deleted the hotfix-main-pr1799 branch February 11, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant