[Hotfix Main]: fix(): Fix edge_split_layers implicit-default warning noise #1801
+196
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix of PR #1799 (#1799) to the
mainbranch.Hey @benflexcompute, please review this hotfix PR created from your original PR.
Note
Low Risk
Small, narrowly-scoped change to params serialization/validation intended to reduce warning noise; risk is limited to accidentally omitting
edge_split_layersin cases where it was meant to be treated as explicitly set.Overview
Reduces spurious validation warnings for
MeshingDefaults.edge_split_layersby treating the default value as non-user-set and stripping the implicitly serialized field from payloads.Adds
strip_implicit_edge_split_layers_inplace()and applies it before local validation (validate_params_with_context) and before draft uploads (Draft.update_simulation_params), while still emitting the existing non-beta warning when users explicitly setedge_split_layers(even to the default). Includes targeted unit tests covering both constructors/model-validate paths and upload/validation behavior.Written by Cursor Bugbot for commit a81fdaf. This will update automatically on new commits. Configure here.