-
Notifications
You must be signed in to change notification settings - Fork 9
[WIP] Schema Migration #1802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[WIP] Schema Migration #1802
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9fb87ae3a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Note
Medium Risk
CI and dependency resolution now rely on AWS CodeArtifact credentials and token fetching, so misconfiguration or outage could break installs/tests/publishing. The new external dependency (
flow360-schemas) may affect runtime behavior if its API/versions diverge.Overview
CI now authenticates Poetry against AWS CodeArtifact via a new composite action (
.github/actions/setup-codeartifact-poetry-auth) that configures AWS credentials, fetches an authorization token, and exportsPOETRY_HTTP_BASIC_*env vars.Workflows (
test.yml,codestyle.yml,pypi-publish.yml) are updated to require/inherit AWS secrets and run the new auth step beforepoetry install.Poetry configuration adds an explicit
codeartifactsource and a new runtime dependencyflow360-schemaspulled from that repository;poetry.lockis regenerated accordingly and a small test (tests/test_artifact_import.py) asserts the artifact package is importable.Written by Cursor Bugbot for commit 0045350. This will update automatically on new commits. Configure here.