[SNAPPY] Adds an option to ignore region edges in edge refinement #1803
+22
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| edges["minLen"] = refinement.min_len.value.item() | ||
| if refinement.retain_on_smoothing is not None: | ||
| edges["retainOnSmoothing"] = refinement.retain_on_smoothing | ||
| edges["geometricTestOnly"] = "yes" if refinement.geometric_test_only else "no" |
There was a problem hiding this comment.
Inconsistent boolean format for geometricTestOnly field
Medium Severity
geometricTestOnly is serialized as a string "yes"/"no", while every other boolean field in the same edges dictionary (e.g., retainOnSmoothing) and elsewhere in the snappy translator output (e.g., multiRegionFeatureSnap, strictRegionSnap) uses a native JSON boolean (true/false). This inconsistency likely means the downstream consumer will receive an unexpected type for this field, potentially causing it to be ignored or misinterpreted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes the mesher JSON schema for Snappy edge refinements by introducing a new field, which could affect downstream mesher behavior or compatibility if not supported.
Overview
Adds a new
geometric_test_onlyboolean tosnappy.SurfaceEdgeRefinementto allow ignoring region edges and performing only geometric edge tests.Updates Snappy surface meshing translation to always emit
edges.geometricTestOnly(as"yes"/"no") in the generated mesher JSON, and refreshes translator fixtures/golden JSON plus tests to cover the new option.Written by Cursor Bugbot for commit 496d025. This will update automatically on new commits. Configure here.