Skip to content

Conversation

@dmarek-flex
Copy link
Contributor

@dmarek-flex dmarek-flex commented Feb 11, 2026

Summary

  • Cherry-pick of SCRF-2777 fix from develop onto v2.10.2 for a 2.10.3 patch
  • Adds early validation of AutoImpedanceSpec in ModeSolver.validate_pre_upload so that microwave mode solver setup errors (e.g., "No valid isolated conductors found") are caught before upload rather than failing during preprocessing
  • Moves the auto impedance validation logic from Simulation into MicrowaveModeSpec._validate_auto_impedance_setup so it can be shared by both Simulation and ModeSolver

Test plan

  • CI passes on patch branch
  • Verify with SCRF-2777 reproduction case (microstrip line with wide ground plane)

🤖 Generated with Claude Code


Note

Medium Risk
Changes pre-upload validation behavior for ModeSolver/microwave monitors, which may surface new SetupErrors earlier for previously-uploaded models; logic is localized to validation paths only.

Overview
Adds client-side pre-upload validation for MicrowaveModeSpec when using AutoImpedanceSpec in ModeSolver, so invalid conductor geometries fail locally instead of producing cryptic server-side preprocessing errors.

Refactors the auto-impedance setup check into MicrowaveModeSpec._validate_auto_impedance_setup (reused by both Simulation monitor validation and the new ModeSolver.validate_pre_upload step), and adds a regression test covering the new early failure. Updates the changelog for 2.10.3.

Written by Cursor Bugbot for commit ff59e25. This will update automatically on new commits. Configure here.

@dmarek-flex dmarek-flex self-assigned this Feb 11, 2026
@dmarek-flex dmarek-flex requested review from daquinteroflex and momchil-flex and removed request for weiliangjin2021 February 11, 2026 14:45
…ate_pre_upload

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dmarek-flex dmarek-flex force-pushed the dmarek/hotfix-2.10-waveport-validation branch from 703e9dd to ff59e25 Compare February 11, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant