fix(tidy3d): SCRF-2777 validate AutoImpedanceSpec in ModeSolver for 2.10.3 #3274
+120
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
v2.10.2for a 2.10.3 patchAutoImpedanceSpecinModeSolver.validate_pre_uploadso that microwave mode solver setup errors (e.g., "No valid isolated conductors found") are caught before upload rather than failing during preprocessingSimulationintoMicrowaveModeSpec._validate_auto_impedance_setupso it can be shared by bothSimulationandModeSolverTest plan
🤖 Generated with Claude Code
Note
Medium Risk
Changes pre-upload validation behavior for
ModeSolver/microwave monitors, which may surface newSetupErrors earlier for previously-uploaded models; logic is localized to validation paths only.Overview
Adds client-side pre-upload validation for
MicrowaveModeSpecwhen usingAutoImpedanceSpecinModeSolver, so invalid conductor geometries fail locally instead of producing cryptic server-side preprocessing errors.Refactors the auto-impedance setup check into
MicrowaveModeSpec._validate_auto_impedance_setup(reused by bothSimulationmonitor validation and the newModeSolver.validate_pre_uploadstep), and adds a regression test covering the new early failure. Updates the changelog for2.10.3.Written by Cursor Bugbot for commit ff59e25. This will update automatically on new commits. Configure here.