Conversation
Signed-off-by: Vlad Iftime <vladiftime60@gmail.com>
There was a problem hiding this comment.
The spec state it's from and not from_. I looked at it some more and see why it's not defined as from(as you can't) . However you seem to already have the suggested workaround of introducing an alias workaround.
Going through the documentation [documentation] populate_by_name. is depricated from pydnatic 2.11, but the suggested alternative doesn't seem tow ork with 2.10
MauriceHendrix
left a comment
MauriceHendrix
left a comment
There was a problem hiding this comment.
On closer inspection, this makese sense
MauriceHendrix
left a comment
MauriceHendrix
left a comment
There was a problem hiding this comment.
However the tests don't seem to work. Look some sort of tox / python version error maybe but I'm not sure
checking it's really a python 3.8 issue
checking if it's a 3.8 issue
reanable 3.8 for tests
testing if it's down to ubuntu version
* dropping python 3.8 adding 3.13 support
MauriceHendrix
left a comment
MauriceHendrix
left a comment
There was a problem hiding this comment.
@VladIftime added python versions fix for the tests as far as I'm concerned you can merge this now
|
I assigned this to v0.6.0. Since this upcoming version will drop support for Python 3.8, in case anyone needs the fix in this PR to work with Python 3.8, drop us a line here. |
3 participants
Fix for #111