Skip to content

Comments

dropping python 3.8 support#117

Merged
MauriceHendrix merged 6 commits intomainfrom
github_ci_python
May 6, 2025
Merged

dropping python 3.8 support#117
MauriceHendrix merged 6 commits intomainfrom
github_ci_python

Conversation

@MauriceHendrix
Copy link
Contributor

@MauriceHendrix MauriceHendrix commented May 6, 2025

Looks like github actions dropped support fro python 3.8 on ubuntu latest, I suggest dropping 3.8 and adding 3.13

Python 3.8 support seems to have been dropped from github actions ubuntu-latest
@Flix6x Flix6x added this to the 0.6.0 milestone May 6, 2025
@MauriceHendrix MauriceHendrix marked this pull request as ready for review May 6, 2025 09:48
@jorritn
Copy link
Contributor

jorritn commented May 6, 2025

If the criterium for Python supported version is that we run the tests, then we should run the tests with Python 3.12 and 3.13 too.

@jorritn
Copy link
Contributor

jorritn commented May 6, 2025

@lfse-slafleur to me it makes sense to only support Python version that explicitly pass our CI/CD pipeline. The drawback is off course that we probably are stricter in Python version requirement than necessary. And also introduce a breaking change by dropping 3.8 support. What do you think of this?

@lfse-slafleur
Copy link
Member

@lfse-slafleur to me it makes sense to only support Python version that explicitly pass our CI/CD pipeline. The drawback is off course that we probably are stricter in Python version requirement than necessary. And also introduce a breaking change by dropping 3.8 support. What do you think of this?

@jorritn Python 3.8 is EOL and 3.9 is fast approaching. To me it makes sense to drop 3.8.

@MauriceHendrix MauriceHendrix merged commit aec41a6 into main May 6, 2025
19 checks passed
@MauriceHendrix MauriceHendrix deleted the github_ci_python branch May 6, 2025 13:17
MauriceHendrix added a commit that referenced this pull request May 6, 2025
* dropping python 3.8 adding 3.13 support
MauriceHendrix added a commit that referenced this pull request May 6, 2025
* dropping python 3.8 adding 3.13 support
VladIftime added a commit that referenced this pull request Jul 9, 2025
* Fix for transition argument

Signed-off-by: Vlad Iftime <vladiftime60@gmail.com>

* Update tests/unit/message_test.py

* Update ci.yml

checking it's really a python 3.8 issue

* Update ci.yml

checking if it's a 3.8 issue

* Update ci.yml

reanable 3.8 for tests

* Update ci.yml

testing if it's down to ubuntu version

* dropping python 3.8 support (#117)

* dropping python 3.8 adding 3.13 support

---------

Signed-off-by: Vlad Iftime <vladiftime60@gmail.com>
Co-authored-by: Dr Maurice Hendrix <maurice.hendrix@tno.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants