Merged
Conversation
Collaborator
Flix6x
commented
May 23, 2025
Flix6x
commented
- I suggest to split up the S2DefaultServer in one part that deals with a default implementation for tokens and challenges, and another part that deals with a default implementation for the HTTP server.
- The S2FastAPI server implementation would use only the first part.
- The methods to start and stop the server seem specific to the default HTTP server, so I am suggesting to remove them from the abstract class. For example, the FastAPI server would not implement these methods, as it is started/stopped in a different way.
…d challenges and part setting up a default HTTP server Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…r' into dev/refactor-default-server
…r' into dev/refactor-default-server
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…r' into dev/refactor-default-server # Conflicts: # src/s2python/authorization/default_server.py # src/s2python/authorization/server.py
VladIftime
reviewed
Jun 2, 2025
Collaborator
VladIftime
left a comment
VladIftime
left a comment
There was a problem hiding this comment.
Looks good! Worked on it together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.