Added Validation to PEBC Message Classes + Tests of the validation#125
Merged
wcoenraads merged 6 commits intoflexiblepower:mainfrom Jun 17, 2025
Merged
Added Validation to PEBC Message Classes + Tests of the validation#125wcoenraads merged 6 commits intoflexiblepower:mainfrom
wcoenraads merged 6 commits intoflexiblepower:mainfrom
Conversation
Added valdation for PEBCAllowedLimitRange and PEBCPowerConstraints + the tests for that validation
wcoenraads
approved these changes
Jun 17, 2025
Collaborator
wcoenraads
left a comment
wcoenraads
left a comment
There was a problem hiding this comment.
Looks good, thanks Andrew!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge requests includes the message level validation for all PEBC message classes where it was relevant. It also includes unit tests for those validators. The validation is based on the S2 Specification.
In the FRBC message types there is validation of the contents of the messages based on the S2 Specification. I based the approach in the PEBC validation methods on FRBC validators.