131: Move wrapping of pydantic exceptions for model validate, setattr, and model_validate_json to the S2MessageComponent mixin instead of wrapping it using the decorator to preserve classmethod on inheritence for model_validate.#132
Merged
lfse-slafleur merged 2 commits intomainfrom Jul 25, 2025
Conversation
…, and model_validate_json to the S2MessageComponent mixin instead of wrapping it using the decorator to preserve classmethod on inheritence for model_validate.
MauriceHendrix
approved these changes
Jul 25, 2025
Contributor
MauriceHendrix
left a comment
MauriceHendrix
left a comment
There was a problem hiding this comment.
Assuming it works, having the ability to properly inherit is very useful. I actually hadn't seen the raise ... fom construct before, nice one!
Member
Author
Thanks! I have tested it locally through pip install -e, but your comment is very valid. I will be adding a test case that tests exactly this behavior! Just in case you are interested: https://docs.python.org/3/tutorial/errors.html#exception-chaining |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #131 on the motivation