fix: update pydantic requirement to allow higher versions#76
Merged
Conversation
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
victorgarcia98
approved these changes
Jan 24, 2025
Collaborator
Author
|
@lfse-slafleur Did you have a particular reason for setting pydantic==2.8.2 as the minimum? If so, I can add it as an inline comment. If not, I assume it was just the latest at the time you updated to pydantic 2, and therefore, a reasonable minimum. |
Member
@Flix6x None other than I might a mistake. I intended |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the pin on pydantic 2.81.
The
pydantic~=2.8.2requirement from #40 is not compatible with Home Assistant2025.1, which runs onpydantic==2.10. Generally, libraries should try to set only minimum requirements, unless an actual issue with a higher dependency has been identified.Inline, next to any dependency constraint, we should try to state the reason for the constraint or even better, cross-reference a GH Issue, so it has a chance of getting resolved later.
Footnotes
Test ran with 2.10.6:
↩