74: Fix typing of catch_and_convert_exceptions decorator so type of c…#87
Conversation
…lasses is the actual class instead of S2MessageComponent.
|
@wcoenraads @MauriceHendrix Considering you are both active at the moment with code, I thought to ask you for this review. |
MauriceHendrix
left a comment
There was a problem hiding this comment.
Looks ok to me.
are you no longer using B_co (line 8)? If so perheps best to remove it
|
@MauriceHendrix Why did you close this PR? |
wcoenraads
left a comment
There was a problem hiding this comment.
Looks good to me! I have to admit I'm not 100% sure why this change would work better with IDEs, but I don't see any issues either so I'm fine to merge.
I actually didn't notice a difference in PyCharm from this change. Autocomplete seemed to work already for fields or functions on the instantiated object (I reproduced the example in your image). Even before installing the Pydantic plugin the autocomplete was available. |
…lasses is the actual class instead of S2MessageComponent.