Skip to content

mh/fix bug in s2_connection #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MauriceHendrix merged 2 commits into from
Mar 12, 2025
Merged

mh/fix bug in s2_connection #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f70fe0d
Update s2_connection.py
MauriceHendrix Mar 12, 2025
3439aa4
Update s2_connection.py
MauriceHendrix Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/s2python/s2_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,13 +322,14 @@ async def wait_till_connection_restart() -> None:
await self.ws.wait_closed()

async def _connect_ws(self) -> None:
ssl_context = ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT)
if not self._verify_certificate:
ssl_context.check_hostname = False
ssl_context.verify_mode = ssl.CERT_NONE

try:
self.ws = await ws_connect(uri=self.url, ssl=ssl_context)
if self.url.startswith("wss://") and not self._verify_certificate:
ssl_context = ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT)
ssl_context.check_hostname = False
ssl_context.verify_mode = ssl.CERT_NONE
self.ws = await ws_connect(uri=self.url, ssl=ssl_context)
else:
self.ws = await ws_connect(uri=self.url)
except (EOFError, OSError) as e:
logger.info("Could not connect due to: %s", str(e))

Expand Down