Skip to content

Comments

S2 messages importable#95

Merged
Flix6x merged 7 commits intomainfrom
feat/all-s2-messages-importable
Mar 19, 2025
Merged

S2 messages importable#95
Flix6x merged 7 commits intomainfrom
feat/all-s2-messages-importable

Conversation

@Flix6x
Copy link
Collaborator

@Flix6x Flix6x commented Mar 18, 2025

Closes #77.

Note that the tests for importing DDBC and PEBC messages are skipped. This is due to a KeyError, which I consider out of scope for this PR. For example:

    abnormal_conditions: bool = GenPEBCInstruction.model_fields["abnormal_conditions"]  # type: ignore[assignment]
                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'abnormal_conditions'

Flix6x added 6 commits March 18, 2025 10:49
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x self-assigned this Mar 18, 2025
@Flix6x Flix6x requested a review from VladIftime March 18, 2025 10:05
Signed-off-by: F.N. Claessen <felix@seita.nl>
Copy link
Collaborator

@VladIftime VladIftime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing it up.

I will fix the DDBC and PEBC messages in a separate PR.

@Flix6x Flix6x merged commit cb8f5e0 into main Mar 19, 2025
19 checks passed
@Flix6x Flix6x deleted the feat/all-s2-messages-importable branch March 19, 2025 09:19
@Flix6x
Copy link
Collaborator Author

Flix6x commented Mar 24, 2025

Follow-up in #98, where we type some of the S2MessageComponents as S2MessageElements rather than S2Messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add all possible s2-messages to the Union

2 participants