Conversation
davidv1992
force-pushed
the
split-package
branch
from
7fec9ce to
a77d547
Compare
wcoenraads
approved these changes
Feb 17, 2026
Contributor
wcoenraads
left a comment
wcoenraads
left a comment
There was a problem hiding this comment.
This looks good to me, I don't see any issues with these changes. This is good to merge as-is. Thanks!
folkertdev
force-pushed
the
split-package
branch
from
a77d547 to
89fbbed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits the s2energy work into multiple crates, with the goal of eventually allowing independent upgrades of the message versions and pairing protocols.
Note, this builds upon #16 and #17, which must be merged first