Added options to ignore cookie headers for tape hash creation and recording a specific range of status codes#22
Open
DylanFC wants to merge 6 commits intoflickr:mainfrom
Open
Added options to ignore cookie headers for tape hash creation and recording a specific range of status codes#22DylanFC wants to merge 6 commits intoflickr:mainfrom
DylanFC wants to merge 6 commits intoflickr:mainfrom
Conversation
added 6 commits
May 13, 2016 15:04
…create tape name hash
…us codes for recording tapes. If the status code of the request is not in this range, a tape will not be created
|
hey @DylanFC |
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the following options to suit my particular needs:
options.recordStatusCodes: Array of integers length 2, e.g. [200, 300]
options.ignoreCookies: true|false
I'm only interested in recording status codes of successful requests, so I'm using this with the range [200,300] in case there are any backend issues when a tape doesn't already exist.
Moreover, my backend uses cookie based sessions so I have to authenticate before making a request to the server. However I don't want to authenticate if there is already a tape recorded. Therefore I need the tape hashes to be created without the cookie header playing a part, as subsequent requests will not have this cookie and therefore would not get the tape that was saved.
Thought these options might be helpful, and thanks for creating this!