Skip to content

chore: fix codespell findings and improve naming #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oxyzenQ wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix codespell findings and improve naming #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .codespellrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[codespell]
skip = Cargo.lock
ignore-words-list = DoubleClick
21 changes: 13 additions & 8 deletions src/chart/comparison.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,13 @@ impl ComparisonChart {
let mut series = Vec::with_capacity(tickers.len());
let mut series_index = FxHashMap::default();
for (i, t) in tickers.iter().enumerate() {
let ser = SerTicker::from_parts(t.ticker);
let ser_ticker = SerTicker::from_parts(t.ticker);

let color = color_map
.get(&ser)
.get(&ser_ticker)
.copied()
.unwrap_or_else(|| default_color_for(t));
let name = name_map.get(&ser).cloned();
let name = name_map.get(&ser_ticker).cloned();

series.push(Series::new(*t, color, name));

Expand Down Expand Up @@ -444,8 +444,8 @@ impl ComparisonChart {
}

fn color_for_or_default(&self, ticker_info: &TickerInfo) -> iced::Color {
let ser = SerTicker::from_parts(ticker_info.ticker);
if let Some((_, c)) = self.config.colors.iter().find(|(s, _)| s == &ser) {
let ser_ticker = SerTicker::from_parts(ticker_info.ticker);
if let Some((_, c)) = self.config.colors.iter().find(|(s, _)| s == &ser_ticker) {
*c
} else {
default_color_for(ticker_info)
Expand Down Expand Up @@ -476,11 +476,16 @@ impl ComparisonChart {
}

fn upsert_config_color(&mut self, ticker_info: TickerInfo, color: iced::Color) {
let ser = SerTicker::from_parts(ticker_info.ticker);
if let Some((_, c)) = self.config.colors.iter_mut().find(|(t, _)| *t == ser) {
let ser_ticker = SerTicker::from_parts(ticker_info.ticker);
if let Some((_, c)) = self
.config
.colors
.iter_mut()
.find(|(t, _)| *t == ser_ticker)
{
*c = color;
} else {
self.config.colors.push((ser, color));
self.config.colors.push((ser_ticker, color));
}
}

Expand Down