refactor: move command creation to podcast manager#17
Closed
Feichtmeier wants to merge 8 commits intomainfrom
Closed
refactor: move command creation to podcast manager#17Feichtmeier wants to merge 8 commits intomainfrom
Feichtmeier wants to merge 8 commits intomainfrom
Conversation
- Upgraded to command_it 9.4.1 for progress/cancellation support - Each EpisodeMedia now owns its downloadCommand with built-in progress - Added PodcastManager.activeDownloads (ListNotifier) to track active downloads - Renamed DownloadManager → DownloadService (stateless operations only) - Removed state tracking from DownloadService (no ChangeNotifier, no maps) - Replaced messageStream with Command.globalErrors for error notifications - Added isDownloaded getter based on command progress (progress == 1.0) - Factory constructor pattern for EpisodeMedia (single getDownload call) - Episodes automatically use local path when downloaded (no copyWithX needed) - Simplified UI: watch command properties directly Benefits: - Commands own execution state (no separate registry) - Single source of truth for download state - Better type safety (all ValueListenable<T>) - Cleaner UI code (no manual state management) - Real-time progress updates and cancellation support
…rite button functionality
…vorite button integration
TODO: create ONE class for all types of playable media - don't use third party libs in library services or player managers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.