fix: suggestions editing #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KirillSergeevich
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem with both editing and creating suggestions. SuggestionsPage has didChangeDependencies method that calls injector init method. During injector init method, SuggestionRepository is recreated, but it is initialized only once, in SuggestionsPage init method. During SuggestionRepository initialization its suggestions behaviour subject is initialized. So when the repository is replaced, suggestions behaviour subject is not initialized with values (empty list) and refreshSuggestions method is not working as it should (cant find the suggestion to update in suggestions list).
Fixed with _isInitialized check