feat(permsets): add maxwaittime attribute to psg awaiter#170
Open
packocz wants to merge 1 commit intoflxbl-io:mainfrom
Open
feat(permsets): add maxwaittime attribute to psg awaiter#170packocz wants to merge 1 commit intoflxbl-io:mainfrom
packocz wants to merge 1 commit intoflxbl-io:mainfrom
Conversation
d3712a3 to
d48b09b
Compare
Author
|
I think I'm now ready with this PR. I added some tests that cover the new behaviour as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to make a start at updating the PSG awaiter, which is causing us a lot of headaches. We have large PSGs and update them very frequently. For some reason every now and then some of them just get stuck at "updating" status for several hours and our development pipelines basically stop.
I wonder what would be a better approach:
SfpPackageInstallationOptionsand update all install/deploy commands to support a new argumentI've had some issues running these tests, though I originally wrote this in the old repository with lerna and there they ran fine. Nevertheless this is a draft only.
Checklist
All items have to be completed before a PR is merged