Introduce new config disable_force_path_style for S3 #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ranjit Kumar Parvathaneni <prk.bits@gmail.com>
|
What is the goal? Can you please help me understand. Thank you for maintaining the default |
Author
We use S3-compatible CAIOS and it usus virtual addressing style. Happy to make the changes to proto as well. Not sure where they are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently within S3 config force path style is hardcoded to be true. Exposing the value via config.
Context
The current config assumes when an endpoint is supplied, it could be something like minio. We use S3-Compatible CAIOS which doesn't use path sytle and uses hostname style.
Related pr in flytekit
#20