-
Notifications
You must be signed in to change notification settings - Fork 3
Less frequent use of back impl #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
arrowsKey' allows specifying which arrows should be shown
| arrowsKey = arrowsKey' [Impl, BackImpl, Equi] | ||
|
|
||
| arrowsKey' :: OutputCapable m => [BinOp] -> LangM m | ||
| arrowsKey' [] = pure () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow the implementation below appears too convoluted to me.
We know that the [BinOp] list passed to here will not contain anything aside from Impl, BackImpl, Equi, right?
Then, for example, op == Equi could simply be the first case, and op == Impl || op == BackImpl could be turned into otherwise.
|
This:
could be reflected now by adding code comments to places like this: logic-tasks/flex/composeFormula.flex Lines 34 to 47 in d495f1f
i.e., something like , (BackImpl, 1) -- should be (BackImpl, 0) in futurein the last line there. |
CLOSE #301