hide plain Config module #338
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You are probably right, but this should most likely be a part of #27. There is a whole Bachelor thesis (more than two years old) still waiting for its code to be merged into this repository. Since that code was written relative to the old/present module hierarchy, it might be better to wait with any restructurings until after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We export both
ConfigandLogicTasks.Config. These modules are currently identical for users (the qualified version just re-exports).I think it would be best to not expose plain
Config, since this name is not very unique and already clashed with some other library when using it in Flex-Tasks.