Address feedback on variable amount of class and object diagrams support #595
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jvoigtlaender <5853832+jvoigtlaender@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Cd/Od phrasing language modules to match the repository’s preferred multi-line formatting for M.fromList data, improving readability and consistency in the numberWords maps used for phrasing.
Changes:
- Reformat
numberWordsin English phrasing to a multi-lineM.fromListlayout. - Reformat
numberWordsin German phrasing to the same multi-line layout.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Modelling/CdOd/Phrasing/English.hs |
Reformats numberWords map definition into a multi-line M.fromList for readability/consistency. |
src/Modelling/CdOd/Phrasing/German.hs |
Applies the same multi-line formatting to the German numberWords map definition. |
Comment on lines
37
to
+40
| numberWords :: Map Int String | ||
| numberWords = M.fromList [(2,"two"),(3,"three"),(4,"four"),(5,"five"),(6,"six"),(7,"seven"),(8,"eight"),(9,"nine"),(10,"ten")] | ||
| numberWords = M.fromList [ | ||
| (2, "two"), | ||
| (3, "three"), |
There was a problem hiding this comment.
PR title is marked "[WIP]" but the description checklist indicates the work is complete. If this is ready, consider removing the WIP marker so it’s clear the PR is intended for merge review.
jvoigtlaender
changed the title
Copilot stopped work on behalf of
jvoigtlaender due to an error
February 10, 2026 08:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numberWordsnumberWordsin English.hsnumberWordsin German.hs✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.