Rename num2word to numberToWord to avoid abbreviations #596
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jvoigtlaender <5853832+jvoigtlaender@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update support for variable amount of class and object diagrams
Rename num2word to numberToWord to avoid abbreviations
Feb 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Renames an internal helper in the CdOd phrasing utilities from an abbreviated identifier (num2word) to a spell-checkable, non-abbreviated name (numberToWord), aligning with the project’s naming guidelines (as discussed in #594).
Changes:
- Renamed
num2word→numberToWordinModelling.CdOd.Phrasingand updated the module export list. - Updated
Modelling.CdOd.MatchCdOdto importnumberToWordand renamed the local fallback helper accordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Modelling/CdOd/Phrasing.hs | Renames the internal number-word lookup helper and its export to avoid abbreviations. |
| src/Modelling/CdOd/MatchCdOd.hs | Updates import and local helper name to use numberToWord consistently in task text generation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renamed
num2wordtonumberToWordthroughout the codebase to comply with naming conventions that avoid abbreviations and ensure spell-checkable identifiers.Changes
src/Modelling/CdOd/Phrasing.hs: Renamed exported functionnum2word→numberToWordsrc/Modelling/CdOd/MatchCdOd.hs: Updated import and renamed local helpernum2wordNumeralFallback→numberToWordNumeralFallbackContext
This PR addresses feedback on #594. The abbreviation
numconflicts with the repository's guideline requiring spell-checkable, non-abbreviated identifiers.Triggering review: #594 (comment)
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.