Refactor based on review feedback: Inline numberToWord #598
+9
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jvoigtlaender <5853832+jvoigtlaender@users.noreply.github.com>
jvoigtlaender
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the Cd/Od phrasing utilities by removing the numberToWord helper and exposing numberWords as the top-level API, then updating MatchCdOd to perform the lookup inline using the exported map.
Changes:
- Replace
numberToWordwith an exportednumberWords :: Language -> Map Int StringinPhrasing.hs. - Update
MatchCdOd.hsto importnumberWordsand inline the map lookup with a numeric fallback. - Remove the now-unused local
numberToWordNumeralFallbackhelper inMatchCdOd.hs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Modelling/CdOd/Phrasing.hs | Removes numberToWord, exports numberWords as the shared language-to-map accessor. |
| src/Modelling/CdOd/MatchCdOd.hs | Switches to numberWords and inlines the lookup logic for task text number phrasing. |
Copilot stopped work on behalf of
jvoigtlaender due to an error
February 10, 2026 10:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numberWordsa top-level definition inPhrasing.hsnumberToWordfunction fromPhrasing.hsPhrasing.hsto exportnumberWordsinstead ofnumberToWordnumberToWordusage inMatchCdOd.hsMatchCdOd.hsto importnumberWordsinstead ofnumberToWord💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.